sandyx
/
libobjc2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix block refcounts to use saturating arithmetic.

Browse Source
main
David Chisnall 8 years ago
parent 5f01917a49
commit 6451d35e92
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File

12
blocks_runtime.m
Unescape Escape View File

@ -60,8 +60,10 @@ static int increment24(int *ref)
{ {
int old = *ref; int old = *ref;
int val = old & BLOCK_REFCOUNT_MASK; int val = old & BLOCK_REFCOUNT_MASK;
// FIXME: We should gracefully handle refcount overflow, but for now we if (val == BLOCK_REFCOUNT_MASK)
// just give up {
return val;
}
assert(val < BLOCK_REFCOUNT_MASK); assert(val < BLOCK_REFCOUNT_MASK);
if (!__sync_bool_compare_and_swap(ref, old, old+1)) if (!__sync_bool_compare_and_swap(ref, old, old+1))
{ {
@ -74,8 +76,10 @@ static int decrement24(int *ref)
{ {
int old = *ref; int old = *ref;
int val = old & BLOCK_REFCOUNT_MASK; int val = old & BLOCK_REFCOUNT_MASK;
// FIXME: We should gracefully handle refcount overflow, but for now we if (val == BLOCK_REFCOUNT_MASK)
// just give up {
return val;
}
assert(val > 0); assert(val > 0);
if (!__sync_bool_compare_and_swap(ref, old, old-1)) if (!__sync_bool_compare_and_swap(ref, old, old-1))
{ {

Write Preview
Loading…
Cancel
Save